Merge ~mertkirpici/juju-lint:topic/juju-3.1 into juju-lint:master

Proposed by Mert Kirpici
Status: Merged
Approved by: Mert Kirpici
Approved revision: cd05408592460d420d1b773a51c7e4553955a3ee
Merged at revision: b0aba6b1fde897f1af7922dcd866cd0e7d63964c
Proposed branch: ~mertkirpici/juju-lint:topic/juju-3.1
Merge into: juju-lint:master
Diff against target: 57 lines (+16/-3)
3 files modified
Makefile (+6/-1)
tests/functional/requirements.txt (+0/-2)
tox.ini (+10/-0)
Reviewer Review Type Date Requested Status
Tianqi Xiao (community) Approve
Robert Gildein Approve
🤖 prod-jenkaas-bootstack continuous-integration Approve
Erhan Sunar Pending
Review via email: mp+451174@code.launchpad.net

Commit message

chore: add juju 3.1 support

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mert Kirpici (mertkirpici) wrote :

waiting for 3.1 pipeline. do not merge yet.

Revision history for this message
Mert Kirpici (mertkirpici) wrote :
Revision history for this message
Robert Gildein (rgildein) :
Revision history for this message
Mert Kirpici (mertkirpici) :
Revision history for this message
Robert Gildein (rgildein) wrote :

LGTM

review: Approve
Revision history for this message
Tianqi Xiao (txiao) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision b0aba6b1fde897f1af7922dcd866cd0e7d63964c

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index 887786e..8a41472 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -19,6 +19,7 @@ help:
6 @echo " make reformat - run black and isort and reformat files"
7 @echo " make unittests - run the tests defined in the unittest subdirectory"
8 @echo " make functional - run the tests defined in the functional subdirectory"
9+ @echo " make functional31 - run the tests defined in the functional subdirectory with juju 3.1 requirements"
10 @echo " make test - run lint, proof, unittests and functional targets"
11 @echo " make pre-commit - run pre-commit checks on all the files"
12 @echo ""
13@@ -57,8 +58,12 @@ functional: build
14 @echo "Executing functional tests using built snap"
15 @TEST_SNAP=${SNAP_FILE} tox -e func -- ${FUNC_ARGS}
16
17+functional31: build
18+ @echo "Executing functional tests using built snap with juju 3.1 requirements"
19+ @TEST_SNAP=${SNAP_FILE} tox -e func31 -- ${FUNC_ARGS}
20+
21 pre-commit:
22 @tox -e pre-commit
23
24 # The targets below don't depend on a file
25-.PHONY: help clean dev-environment build lint reformat unittests functional test pre-commit
26+.PHONY: help clean dev-environment build lint reformat unittests functional functional31 test pre-commit
27diff --git a/tests/functional/requirements.txt b/tests/functional/requirements.txt
28index eab92d5..6a1cad4 100644
29--- a/tests/functional/requirements.txt
30+++ b/tests/functional/requirements.txt
31@@ -1,5 +1,3 @@
32 pytest
33 pytest-operator
34 pytest-httpserver
35-# pin juju library to maintain compatibility with Juju controller < 3.0
36-juju < 3.0
37diff --git a/tox.ini b/tox.ini
38index f6d4326..65fe08d 100644
39--- a/tox.ini
40+++ b/tox.ini
41@@ -61,6 +61,16 @@ setenv = PYTHONPATH={toxinidir}
42 deps =
43 -r{toxinidir}/tests/functional/requirements.txt
44 -r{toxinidir}/requirements.txt
45+ juju<3
46+passenv =
47+ TEST_*
48+commands =
49+ pytest {toxinidir}/tests/functional {posargs:-v}
50+
51+[testenv:func31]
52+deps =
53+ -r{toxinidir}/tests/functional/requirements.txt
54+ -r{toxinidir}/requirements.txt
55 passenv =
56 TEST_*
57 commands =

Subscribers

People subscribed via source and target branches