Merge ~mertkirpici/juju-lint:lp/1995479 into juju-lint:master

Proposed by Mert Kirpici
Status: Rejected
Rejected by: Mert Kirpici
Proposed branch: ~mertkirpici/juju-lint:lp/1995479
Merge into: juju-lint:master
Diff against target: 28 lines (+3/-0)
2 files modified
tests/functional/requirements.txt (+1/-0)
tox.ini (+2/-0)
Reviewer Review Type Date Requested Status
Gabriel Cocenza Disapprove
🤖 prod-jenkaas-bootstack continuous-integration Approve
Eric Chen Needs Fixing
Review via email: mp+432487@code.launchpad.net

Commit message

Close LP #1995479

Description of the change

Functests seem to get stuck with libjuju 3.0.4. Also PYTHONPATH variables were missing from the functests that use the python package.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Eric Chen (eric-chen) wrote :

This modification seems conflicts with the conclusion in LP #1993334 that we need to use pylibjuju >= 3.0.4. I prefer to dig into deeper and find out the root cause.

review: Needs Fixing
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gabriel Cocenza (gabrielcocenza) wrote :

The problem was an incompatibility issue between python-libjuju and the version of the controller. Updating the controller to the latest stable version solved the issue.

review: Disapprove

Unmerged commits

a60dc92... by Mert Kirpici

tests/functional: pin juju to 3.0.2

Works-on: 1995479
Signed-off-by: Mert Kırpıcı <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/functional/requirements.txt b/tests/functional/requirements.txt
2index f7fed82..da81487 100644
3--- a/tests/functional/requirements.txt
4+++ b/tests/functional/requirements.txt
5@@ -1,2 +1,3 @@
6 pytest
7 pytest-operator
8+juju==3.0.2
9diff --git a/tox.ini b/tox.ini
10index 08183e2..9a9b8f3 100644
11--- a/tox.ini
12+++ b/tox.ini
13@@ -56,6 +56,7 @@ commands =
14 --log-cli-level=WARNING \
15 --ignore={toxinidir}/tests/unit \
16 -m smoke
17+setenv = PYTHONPATH={toxinidir}
18
19 [testenv:func-dev]
20 deps =
21@@ -65,6 +66,7 @@ commands =
22 pytest -v \
23 --log-cli-level=WARNING \
24 --ignore={toxinidir}/tests/unit
25+setenv = PYTHONPATH={toxinidir}
26
27 [testenv:lint]
28 deps =

Subscribers

People subscribed via source and target branches