Code review comment for lp:~merlijn-sebrechts/xpad/better_menus

Hi Merlijn, Thans for making the change. I will redo the merge and test.

For the README I believe you are partially correct.

Developers have to run the autogen.sh, that is true.
However, the 'ready' packages which users can download at the launchpad
website (https://launchpad.net/xpad) are already prepared. In fact, I do
run the autogen.sh for them when creating this package.

For the make install, I believe you are right. I will add the fact that you
have to run the 'make install' as root. Good point.
Thank you for your help.

Stay tuned. :)

On 21 December 2014 at 12:31, Merlijn Sebrechts <<email address hidden>
> wrote:

> I switched edit and close. I also found a bug in the README. It didn't
> mention autogen.sh, and it didn't mention make install should be run as
> root.
> --
>
> https://code.launchpad.net/~merlijn-sebrechts/xpad/better_menus/+merge/244712
> You are requested to review the proposed merge of
> lp:~merlijn-sebrechts/xpad/better_menus into lp:xpad.
>

--
Arthur Borsboom
Lieven de Keystraat 77
3067 KG, Rotterdam
The Netherlands
Mob: +31629089953
Email: <email address hidden>
Skype: Arthur Borsboom, The Hague, The Netherlands

[image: View Arthur's LinkedIn profile]
<http://uk.linkedin.com/in/arthurborsboom>