Merge lp:~mehra-vinayak/timer-applet/remove-unused-imports into lp:timer-applet

Proposed by Kenny Meyer
Status: Work in progress
Proposed branch: lp:~mehra-vinayak/timer-applet/remove-unused-imports
Merge into: lp:timer-applet
Diff against target: 36 lines (+1/-3)
3 files modified
timer-applet/po/LINGUAS (+0/-1)
timer-applet/src/timerapplet/controllers/TimerApplet.py (+0/-1)
timer-applet/src/timerapplet/core/PresetsStore.py (+1/-1)
To merge this branch: bzr merge lp:~mehra-vinayak/timer-applet/remove-unused-imports
Reviewer Review Type Date Requested Status
Kenny Meyer Needs Fixing
Review via email: mp+44994@code.launchpad.net

Commit message

Remove unused imports from source files

To post a comment you must log in.
Revision history for this message
Kenny Meyer (knny-myer) wrote :

It seems like you haven't committed your changes. Please do that.

review: Needs Fixing
Revision history for this message
vinayak (mehra-vinayak) wrote :

> It seems like you haven't committed your changes. Please do that.

Committed the changes .

348. By vinayak

"Committing the changes in the branch for review"

Revision history for this message
vinayak (mehra-vinayak) wrote :

Hi Kenny ,

I have done the changes ,commiteed them and pushed the changes to branch .Please review

Regards

Revision history for this message
Kenny Meyer (knny-myer) wrote :

Sorry, for the long delay in response.

You weren't supposed to modify timer-applet/po/LINGUAS. Please make another commit to revert removing `es'. That's needed so translation will be compiled later on.

Otherwise it looks fine! :)

review: Needs Fixing

Unmerged revisions

348. By vinayak

"Committing the changes in the branch for review"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'timer-applet/po/LINGUAS'
--- timer-applet/po/LINGUAS 2008-12-01 16:10:15 +0000
+++ timer-applet/po/LINGUAS 2011-01-02 11:08:10 +0000
@@ -7,7 +7,6 @@
7en_AU7en_AU
8en_GB8en_GB
9eo9eo
10es
11eu10eu
12fa11fa
13fi12fi
1413
=== modified file 'timer-applet/src/timerapplet/controllers/TimerApplet.py'
--- timer-applet/src/timerapplet/controllers/TimerApplet.py 2010-11-28 10:15:32 +0000
+++ timer-applet/src/timerapplet/controllers/TimerApplet.py 2011-01-02 11:08:10 +0000
@@ -22,7 +22,6 @@
22import gst22import gst
23import gtk23import gtk
24import gtk.glade as glade24import gtk.glade as glade
25import gtk.gdk as gdk
26import subprocess25import subprocess
27import shlex26import shlex
28import threading27import threading
2928
=== modified file 'timer-applet/src/timerapplet/core/PresetsStore.py'
--- timer-applet/src/timerapplet/core/PresetsStore.py 2010-09-15 12:29:45 +0000
+++ timer-applet/src/timerapplet/core/PresetsStore.py 2011-01-02 11:08:10 +0000
@@ -24,7 +24,7 @@
24from os import path24from os import path
25import gobject25import gobject
26import gtk26import gtk
27import timerapplet.utils as utils27
2828
29from timerapplet.utils import (serialize_bool,29from timerapplet.utils import (serialize_bool,
30 deserialize_bool,30 deserialize_bool,

Subscribers

People subscribed via source and target branches

to all changes: