Merge lp:~meese/pantheon-photos/fix1275112 into lp:~pantheon-photos/pantheon-photos/trunk

Proposed by meese
Status: Merged
Approved by: Danielle Foré
Approved revision: 2546
Merged at revision: 2546
Proposed branch: lp:~meese/pantheon-photos/fix1275112
Merge into: lp:~pantheon-photos/pantheon-photos/trunk
Diff against target: 69 lines (+6/-13)
4 files modified
src/CollectionPage.vala (+0/-10)
ui/collection.ui (+3/-0)
ui/photo.ui (+0/-3)
ui/photo_context.ui (+3/-0)
To merge this branch: bzr merge lp:~meese/pantheon-photos/fix1275112
Reviewer Review Type Date Requested Status
Danielle Foré Approve
Review via email: mp+226104@code.launchpad.net

Commit message

Moves copy and paste color adjustments out of menubar and into context menu

Description of the change

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

Works here! Thanks Madelynn!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/CollectionPage.vala'
--- src/CollectionPage.vala 2014-05-22 07:11:31 +0000
+++ src/CollectionPage.vala 2014-07-09 10:46:06 +0000
@@ -96,15 +96,6 @@
96 96
97 return group;97 return group;
98 }98 }
99
100 private static InjectionGroup create_photos_menu_edits_injectables() {
101 InjectionGroup group = new InjectionGroup("/MenuBar/PhotosMenu/PhotosExtrasEditsPlaceholder");
102
103 group.add_menu_item("CopyColorAdjustments");
104 group.add_menu_item("PasteColorAdjustments");
105
106 return group;
107 }
108 99
109 private static InjectionGroup create_photos_menu_date_injectables() {100 private static InjectionGroup create_photos_menu_date_injectables() {
110 InjectionGroup group = new InjectionGroup("/MenuBar/PhotosMenu/PhotosExtrasDateTimePlaceholder");101 InjectionGroup group = new InjectionGroup("/MenuBar/PhotosMenu/PhotosExtrasDateTimePlaceholder");
@@ -229,7 +220,6 @@
229 groups += create_file_menu_injectables();220 groups += create_file_menu_injectables();
230 groups += create_edit_menu_injectables();221 groups += create_edit_menu_injectables();
231 groups += create_view_menu_fullscreen_injectables();222 groups += create_view_menu_fullscreen_injectables();
232 groups += create_photos_menu_edits_injectables();
233 groups += create_photos_menu_date_injectables();223 groups += create_photos_menu_date_injectables();
234 groups += create_photos_menu_externals_injectables();224 groups += create_photos_menu_externals_injectables();
235 225
236226
=== modified file 'ui/collection.ui'
--- ui/collection.ui 2014-05-27 06:18:57 +0000
+++ ui/collection.ui 2014-07-09 10:46:06 +0000
@@ -3,6 +3,9 @@
3 <menuitem name="ContextEnhance" action="Enhance" />3 <menuitem name="ContextEnhance" action="Enhance" />
4 <menuitem name="ContextRevert" action="Revert" />4 <menuitem name="ContextRevert" action="Revert" />
5 <separator />5 <separator />
6 <menuitem name="ContextCopyColorAdjustments" action="CopyColorAdjustments" />
7 <menuitem name="ContextPasteColorAdjustments" action="PasteColorAdjustments" />
8 <separator />
6 <menuitem name="ContextAddTags" action="AddTagsContextMenu" />9 <menuitem name="ContextAddTags" action="AddTagsContextMenu" />
7 <menuitem name="ContextModifyTags" action="ModifyTags" />10 <menuitem name="ContextModifyTags" action="ModifyTags" />
8 <placeholder name="ContextTagsPlaceholder" />11 <placeholder name="ContextTagsPlaceholder" />
912
=== modified file 'ui/photo.ui'
--- ui/photo.ui 2014-06-06 01:18:33 +0000
+++ ui/photo.ui 2014-07-09 10:46:06 +0000
@@ -25,9 +25,6 @@
25 <menuitem name="FlipHorizontally" action="FlipHorizontally" />25 <menuitem name="FlipHorizontally" action="FlipHorizontally" />
26 <menuitem name="FlipVertically" action="FlipVertically" />26 <menuitem name="FlipVertically" action="FlipVertically" />
27 <separator />27 <separator />
28 <menuitem name="CopyColorAdjustments" action="CopyColorAdjustments" />
29 <menuitem name="PasteColorAdjustments" action="PasteColorAdjustments" />
30 <separator/>
31 <menuitem name="AdjustDateTime" action="AdjustDateTime" />28 <menuitem name="AdjustDateTime" action="AdjustDateTime" />
32 </menu>29 </menu>
3330
3431
=== modified file 'ui/photo_context.ui'
--- ui/photo_context.ui 2013-02-28 01:46:30 +0000
+++ ui/photo_context.ui 2014-07-09 10:46:06 +0000
@@ -3,6 +3,9 @@
3 <menuitem name="ContextEnhance" action="Enhance" />3 <menuitem name="ContextEnhance" action="Enhance" />
4 <menuitem name="ContextRevert" action="Revert" />4 <menuitem name="ContextRevert" action="Revert" />
5 <separator />5 <separator />
6 <menuitem name="ContextCopyColorAdjustments" action="CopyColorAdjustments" />
7 <menuitem name="ContextPasteColorAdjustments" action="PasteColorAdjustments" />
8 <separator />
6 <menuitem name="ContextAddTags" action="AddTagsContextMenu" />9 <menuitem name="ContextAddTags" action="AddTagsContextMenu" />
7 <menuitem name="ContextModifyTags" action="ModifyTags" />10 <menuitem name="ContextModifyTags" action="ModifyTags" />
8 <placeholder name="ContextTagsPlaceholder" />11 <placeholder name="ContextTagsPlaceholder" />

Subscribers

People subscribed via source and target branches

to all changes: