Code review comment for lp:~meese/pantheon-photos/fix-1321029

Revision history for this message
Corentin Noël (tintou) wrote :

The implementation is right, I found some issues with the codestyle.
I would prefer the use of Gtk.Image.from_gicon as explained in the inline diff: IMO currently the icons are too gib and are inconsistent with the open with menu from Files, using IconSize.MENU will fix this for sure.

review: Needs Fixing

« Back to merge proposal