Code review comment for ~medicalwei/plainbox-provider-checkbox:fix-audio-test

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

The issue you're facing here is all because pm_test and its way to restart sessions:
https://git.launchpad.net/plainbox-provider-checkbox/tree/bin/pm_test.py#n288

When restarting checkbox after a reboot it opens a terminal and run sudo -u $USER basically. That does not preserve all the desktop env vars we used to get from a genuine desktop user session.

It's something that we do support via checkbox remote.

The checkbox-ng remote service takes care of that: https://git.launchpad.net/checkbox-ng/commit/plainbox/impl/session/remote_assistant.py?id=2938b1da085ae093fedc30114e91f0792133a409

We're planning to kill pm_test.py from all our jobs and push to adopt REMOTE for all QA testing.

So needless to fix anything at audio_test level, definitely not the right place. Please give remote a go, all com.canonical.certification::audio jobs should work just fine after a reboot of the DUT.

review: Disapprove

« Back to merge proposal