Code review comment for lp:~mdragon/nova/xs-console

Revision history for this message
Monsyne Dragon (mdragon) wrote :

> I'm not sure I follow the utility of having the driver.ConsoleProxy class. It
> looks to be an abstract class of sorts, except in every subclassing you re-
> implement every method. I would understand the utility if it seemed a lot of
> the functionality could be passed down, but as is it seems to be an
> unnecessary contract. Am I missing something?

Nope. I was thinking there would be more common code, but not so. I have removed the driver.ConsoleProxy class. (leave that to future refactorings if need be, once we actually have more than 1 real console driver class.)

« Back to merge proposal