Merge ~mdeslaur/ubuntu-cve-tracker:more_cvelib_caching into ubuntu-cve-tracker:master

[Marc Deslauriers]

commit 7b18c2bd59198d9eefe61dc0ce2a6b57b661f582
Author: Marc Deslauriers <email address hidden>
Date: Wed Mar 13 13:35:25 2024 -0400

    cve_lib.py: add more caching to small static cve_lib functions

This brings down ubuntu-table runtime, which is used by cve_need_retire and other things:

BEFORE:
$ time ./scripts/cve_need_retire

real 2m7.587s
user 2m6.066s
sys 0m1.522s

AFTER:
$ time ./scripts/cve_need_retire

real 0m46.135s
user 0m44.484s
sys 0m1.652s

[Alex Murray (alexmurray)]

LGTM (I wonder if whether we should change some of our internal data structures to be sets rather than lists to help with the performance of testing presence etc?)

review: Approve

[Marc Deslauriers (mdeslaur)]

Yeah, that would definitely improve performance...we tend to just use lists by default when adding new features, but sets would be better in a lot of cases. I'll take a closer look at cve_lib when I get a minute.

diff --git a/scripts/cve_lib.py b/scripts/cve_lib.py
index 91aa59c..49694fb 100755
--- a/scripts/cve_lib.py
+++ b/scripts/cve_lib.py
@@ -2756,13 +2756,14 @@ def split_overlay_ppa_from_release(rel):
 
     return rel.split('/')
 
-
+@lru_cache(maxsize=None)
 def is_active_release(rel):
     return rel not in eol_releases
 
 
 # takes a standard release name
 # XXX should perhaps adjust that
+@lru_cache(maxsize=None)
 def is_active_esm_release(rel, component='main'):
     if not is_active_release(rel) or \
         component == 'universe' or component == 'multiverse':
@@ -2771,6 +2772,7 @@ def is_active_esm_release(rel, component='main'):
             return esm_rel not in eol_releases
     return False
 
+@lru_cache(maxsize=None)
 def get_active_releases_with_esm():
     """Return Ubuntu releases with, at least, one active ESM release."""
     active_esm_releases = []
@@ -2788,6 +2790,7 @@ def get_active_releases_with_esm():
 
     return active_esm_releases
 
+@lru_cache(maxsize=None)
 def get_active_esm_releases():
     """Return all active ESM releases."""
     active_esm_releases = []
@@ -2799,6 +2802,7 @@ def get_active_esm_releases():
     return set(active_esm_releases)
 
 # Defaults to main for historical reasons
+@lru_cache(maxsize=None)
 def get_esm_name(rel, component='main'):
     if rel in esm_releases:
         return rel + '/esm'