Merge ~mdeslaur/ubuntu-cve-tracker:perf-part5 into ubuntu-cve-tracker:master

[Marc Deslauriers]

commit 76ecba2f928f6757122b4a5d78b3380af47a0b79
Author: Marc Deslauriers <email address hidden>
Date: Thu Mar 7 10:44:11 2024 -0500

    cve_lib.py: add caching to product_series() as it is used often

commit edb4ba8712239aa6705bf6c93bc1891c4d1fe774
Author: Marc Deslauriers <email address hidden>
Date: Thu Mar 7 10:43:36 2024 -0500

    check-syntax: don't call pkg_ever_existed() for every release

commit 7145416e263bbebf36207a9358a4e536d03c239d
Author: Marc Deslauriers <email address hidden>
Date: Thu Mar 7 10:35:01 2024 -0500

    check-syntax: improve ever_existed() performance

    We don't need to parse through lists of releases and eol releases,
    we just need to see if the package exists in the source map.

more performance changes.

BEFORE:
$ time ./scripts/check-syntax -j8

real 0m50.450s
user 6m15.385s
sys 0m7.404s

AFTER:
$ time ./scripts/check-syntax -j8

real 0m38.672s
user 4m50.809s
sys 0m6.109s

[Alex Murray (alexmurray)]

LGTM!

review: Approve

diff --git a/scripts/check-syntax b/scripts/check-syntax
index 78640b3..d4e4aaf 100755
--- a/scripts/check-syntax
+++ b/scripts/check-syntax
@@ -95,10 +95,8 @@ def CVEs_from_CNA():
 
 
 def ever_existed(pkg):
-    for rel in cve_lib.all_releases:
-        if rel in cve_lib.eol_releases:
-            continue
-        if rel in source and pkg in source[rel]:
+    for rel in source:
+        if pkg in source[rel]:
             return True
     return False
 
@@ -599,6 +597,7 @@ def check_cve(cve):
 
     supported = []
     for pkg in sorted(data["pkgs"].keys()):
+        pkg_ever_existed = ever_existed(pkg)
         # Verify have required releases for each package
         listed_releases = set(sorted(data["pkgs"][pkg].keys()))
         all_required_releases = (set(cve_lib.all_releases + ["devel"]) - set([cve_lib.devel_release])) - set(cve_lib.eol_releases)
@@ -806,7 +805,7 @@ def check_cve(cve):
                     cve_okay = False
 
             # Check that package exists in a given release
-            if not ever_existed(pkg):
+            if not pkg_ever_existed:
                 if is_active(cvepath) and not cve_lib.is_active_esm_release(release):
                     # forcibly skip linux-lts-backport packages and #
                     # other derived kernels since want to track them
diff --git a/scripts/cve_lib.py b/scripts/cve_lib.py
index 07fc8e1..a3104fa 100755
--- a/scripts/cve_lib.py
+++ b/scripts/cve_lib.py
@@ -720,7 +720,7 @@ subprojects = {
     }
 }
 
-
+@lru_cache(maxsize=None)
 def product_series(rel):
     """Return the product,series tuple for rel."""
     if rel in external_releases: