Code review comment for lp:~mcveat/tomdroid/loggers-cleanup

Revision history for this message
Piotr Adamski (mcveat) wrote :

On Thu, Oct 27, 2011 at 2:25 PM, Alex Belisle Turcot
<email address hidden> wrote:
> Bu then, would the debug Strings be created every time, even when logging is
> not enabled ?

I was also concerned about that.

> Current logging frameworks ensure sure that debug Strings are not
> concatenated unless debug is enabled. I'm not sure how to do that in
> Android, you may need to code this mini-framework yourself...

Should be pretty straightforward, yet not so versatile with use of
java.text.MessageFormat and varargs. I'll try how it rolls this
evening.

Regards
Piotr

« Back to merge proposal