Code review comment for ~mclemenceau/casper:master
Revision history for this message
| Dimitri John Ledkov (xnox) wrote | # |
review:
Approve
(just an fyi for the future)
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
If the git changelog was formatted like this:
"""
Update manpage with undocumented cmdline options
LP: #1875548
"""
gbp dch (from git-buildpackage) could have been used to autogenerate debian/changelog.
Also, style wise. Normally one just ends the changelog entry with "(LP: #NNNN)" or "LP: #NNNN" without explicitely making it a sentence i.e. "Resolve (LP: #NNNN)". It is widely understood that LP: # closes a bug number.