Code review comment for lp:~mcintire-evan/unity/add_screenshot_shortcut_hints

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Hi, thanks for you contribution.

Please, revert the changes in the po folder, these are generated automatically.

As for making this option dynamic I think there's some little more work involved:
 - enable the GNOME option type in AbstractShortcutHint.h
 - inside ShortcutHint.cpp read the options from:
   org.gnome.settings-daemon.plugins.media-keys <key_name>
   You can see how to read gsettings from UnitySettings.cpp,
   while in GnomeGrabber::Impl::GrabDBusAccelerator you can see how
   to parse them.
 - In CompizShortcutModeller.cpp you should add something like:
     std::make_shared<shortcut::Hint>(menubar, "", "", _("Take a screenshot."),
                                      shortcut::OptionType::GNOME,
                                      "screenshot")
     std::make_shared<shortcut::Hint>(menubar, "", "", _("Take a screenshot of the current window."),
                                      shortcut::OptionType::GNOME,
                                      "window-screenshot")

It should be fun :)

« Back to merge proposal