Code review comment for lp:~mcintire-evan/ubuntu-terminal-app/window-font-size

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

I guess you decided to set the values from the 'Component.onCompleted' event in order to prevent the window size from being updated after a change of the font size.

That's okay to me, it's the Konsole behaviour we discussed earlier.

Looks good to me! Thanks Evan!

review: Approve

« Back to merge proposal