Code review comment for lp:~mcintire-evan/ubuntu-terminal-app/disable-copy

Revision history for this message
Niklas Wenzel (nikwen) wrote :

I should have made it a bit clearer what I've been referring to with the semicolons. :D

We do use semicolons for executions of commands, e.g. in JavaScript code blocks surrounded by {} and in other execution blocks like onTriggered or onClicked listeners.
We do not use semicolons for QML bindings, i.e. when a value is assigned to a property using a colon.

Examples for when we do use a semicolon:

onTriggered: {
    console.log("test");
    terminalPage.state = "SELECTION";
}

onTriggered: terminalPage.state = "SELECTION";

Examples for when we don't use semicolons:

width: units.gu(2)

text: i18n.tr("Select")

enabled: !terminal.isSelectionEmpty()

I hope that this has made it a little bit clearer. If not, please ask! ;)

« Back to merge proposal