Code review comment for lp:~mcintire-evan/ubuntu-terminal-app/auto-focus-auth

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Yes, it's more a workaround than a "rock-solid" solution, but it does the job well and don't require to change things where it's not strictly required.

Below the Timer {}, I see that you left the Component.onCompleted handler. It isn't necessary anymore.

Anyway, LGTM, so there's no reason why I shouldn't approve it. Great work! :)

review: Approve

« Back to merge proposal