Code review comment for lp:~mc-return/compiz/compiz0.9.9.merge-plugin-screensaver

Revision history for this message
MC Return (mc-return) wrote :

Sam, how should we continue this journey ?

I guess "PKGDEPS xscrnsaver" needs to be changed to "PKGDEPS libxss-dev" ?

Also I would still like to avoid excluding screensaver from the .deb package,
because most people would most probably never be able to use this great plugin...

I understand that we do not want to add a new dependency and you mentioned:

"We could make the dependency conditional.

I know that the dependency on libxss-dev is only there for the
screensaver timeout logic. That can be conditionally compiled, so
users of the ubuntu package won't get the timeout-to-screensaver
functionality."

I would like to help implementing that.
We could maybe use some internal Compiz timer to add that functionality
to the Compiz toolbox and not to have to depend on libxss-dev at all.

I am sure you have an idea on how to best achieve that, Sam ;)

review: Needs Information

« Back to merge proposal