Code review comment for lp:~mc-return/compiz/compiz0.9.9.merge-plugin-screensaver

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

On Fri, Jan 4, 2013 at 11:55 AM, Daniel van Vugt
<email address hidden> wrote:
> Review: Needs Fixing
>
> A few things need attention...
>
> 1. How do I build it? "package 'xscrnsaver' not found". Where do I get the cmake/pkgconfig package 'xscrnsaver'?
>

sudo apt-get install libxss-dev

Does the plugin automatically disable itself for building if that's
not found? If so, then it probably should.

> 2. If you can build it, does it really build with BUILD_GLES=ON? If not, then please disable it for BUILD_GLES in plugins/CMakeLists.txt
>
> 3. Copyrights and license info is missing. We can't use someone else's code if we don't know the license conditions.

The author is Nicholas Viennot and the licence is GPL v2 . That's only
from memory though, I'll see if I can find the actual licence file.

>
> --
> https://code.launchpad.net/~mc-return/compiz/compiz0.9.9.merge-plugin-screensaver/+merge/141533
> You are reviewing the proposed merge of lp:~mc-return/compiz/compiz0.9.9.merge-plugin-screensaver into lp:compiz.

--
Sam Spilsbury

« Back to merge proposal