Code review comment for lp:~mc-return/compiz/compiz0.9.9.merge-plugin-screensaver

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

A few things need attention...

1. How do I build it? "package 'xscrnsaver' not found". Where do I get the cmake/pkgconfig package 'xscrnsaver'?

2. If you can build it, does it really build with BUILD_GLES=ON? If not, then please disable it for BUILD_GLES in plugins/CMakeLists.txt

3. Copyrights and license info is missing. We can't use someone else's code if we don't know the license conditions.

review: Needs Fixing

« Back to merge proposal