Code review comment for lp:~mc-return/compiz/compiz0.9.9.merge-plugin-screensaver

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

@MCR1 can you check that?

Building a GLES build requires that you have a compatible libGLESv2
installed. That can be done with the radeon driver installed, not so
sure about fglrx. Pass -BUILD_GLES=ON to cmake.

Building with clang is relatively straightforward to. Install clang
and clang++ and pass -CMAKE_C_COMPILER=/usr/bin/clang
-CMAKE_CXX_COMPILER=/usr/bin/clang++

Though, I note that requiring reviewers and submitters to rebuild
everything three times is a bit time consuming and silly, especially
when this is a job that could be done by continuous integration. Can
we have a look into that?

(Also, why isn't the ps-jenkins-bot running on reviews that don't
originate from members who have commit access?)

« Back to merge proposal