Merge lp:~mc-return/compiz/compiz.merge-plugin-trip into lp:compiz/0.9.8
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Daniel van Vugt on 2012-07-11 | ||||
| Approved revision: | 3279 | ||||
| Merged at revision: | 3281 | ||||
| Proposed branch: | lp:~mc-return/compiz/compiz.merge-plugin-trip | ||||
| Merge into: | lp:compiz/0.9.8 | ||||
| Diff against target: |
905 lines (+879/-0) 5 files modified
plugins/trip/CMakeLists.txt (+5/-0) plugins/trip/VERSION (+1/-0) plugins/trip/src/trip.cpp (+578/-0) plugins/trip/src/trip.h (+192/-0) plugins/trip/trip.xml.in (+103/-0) |
||||
| To merge this branch: | bzr merge lp:~mc-return/compiz/compiz.merge-plugin-trip | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel van Vugt | 2012-07-04 | Approve on 2012-07-05 | |
| Didier Roche | 2012-07-11 | Pending | |
|
Review via email:
|
|||
Commit Message
Added the plug-in "Trip" converted from git to bzr (including full history) to Compiz.
Description of the Change
Adds the plug-in "Trip" converted from git to bzr (including full history) to Compiz.
UNBLOCK
| MC Return (mc-return) wrote : | # |
| Unity Merger (unity-merger) wrote : | # |
The Jenkins job https:/
Not merging it.
| Daniel van Vugt (vanvugt) wrote : | # |
Needs downstream packaging to get Jenkins approval...
dh_install: usr/share/
dh_install: usr/lib/
dh_install: missing files, aborting
| Didier Roche (didrocks) wrote : | # |
@Daniel: package change done, BUT:
not sure why this has an unblock as gsettings/tests was supposively the only code entering to trunk before next snapshot.
Btw, I think now all plugins/new code entering the code will need tests. I won't accept anymore code without test to enter ubuntu.
| Daniel van Vugt (vanvugt) wrote : | # |
Sorry; I had no idea if or why lp:compiz was frozen. So tried UNBLOCK on everything.
Yes, tests are important. But not for "unsupported" plugins like this one.
| Didier Roche (didrocks) wrote : | # |
@Daniel: it is important, it's in ubuntu, can be installed by people and affect the overall experience


This one *should* work, at least it does here (Ubuntu 12.10, latest Compiz 0.9.8).
It is quite useless, just like the water plug-in, but still is very nice to show off Compiz, just like the water plug-in :)
Seems something went wrong with my commit message (r3279), sorry about that.