the xml cleanup is fine.
957 - ${GMOCK_LIBRARY} 958 - ${GMOCK_MAIN_LIBRARY}) 959 + ${GMOCK_LIBRARY})
GMOCK_MAIN_LIBRARY is necessary here.
1019 +/* 1020 if (cw == mGrabWindow) 1021 { 1022 - /* TODO: Remove these magic numbers */ 1023 - xwc.x = workarea.x () + 50; 1024 - xwc.y = workarea.y () + 50; 1025 + int snapoffThreshold = optionGetSnapoffThreshold (); 1026 + 1027 + xwc.x = workarea.x () + snapoffThreshold; 1028 + xwc.y = workarea.y () + snapoffThreshold; 1029 xwc.width = workarea.width (); 1030 xwc.height = workarea.height (); 1031 cw->configureXWindow (CWX | CWY, &xwc); 1032 } 1033 +*/
I think this ensures the window is moved back on-screen. Not sure though.
Gotta run, will do the rest of the review later.
« Back to merge proposal
the xml cleanup is fine.
957 - ${GMOCK_LIBRARY} MAIN_LIBRARY} )
958 - ${GMOCK_
959 + ${GMOCK_LIBRARY})
GMOCK_MAIN_LIBRARY is necessary here.
1019 +/* fThreshold (); indow (CWX | CWY, &xwc);
1020 if (cw == mGrabWindow)
1021 {
1022 - /* TODO: Remove these magic numbers */
1023 - xwc.x = workarea.x () + 50;
1024 - xwc.y = workarea.y () + 50;
1025 + int snapoffThreshold = optionGetSnapof
1026 +
1027 + xwc.x = workarea.x () + snapoffThreshold;
1028 + xwc.y = workarea.y () + snapoffThreshold;
1029 xwc.width = workarea.width ();
1030 xwc.height = workarea.height ();
1031 cw->configureXW
1032 }
1033 +*/
I think this ensures the window is moved back on-screen. Not sure though.
Gotta run, will do the rest of the review later.