Code review comment for lp:~mc-return/compiz/compiz.merge-fix966099-add-unmaximize-or-minimize-window-key

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

1. This is a pointless statement:
+ if (((w->priv->state & MAXIMIZE_STATE) == MAXIMIZE_STATE) ||
+ (w->priv->state & CompWindowStateMaximizedHorzMask) ||
+ (w->priv->state & CompWindowStateMaximizedVertMask))
and is equivalent to:
    if (w->priv->state & MAXIMIZE_STATE)

2. If design approved this I think they made a mistake. Compiz already has key combinations unmaximize_window_key and minimize_window_key. It's redundant to add a new combo that overlaps those.

review: Disapprove

« Back to merge proposal