Merge lp:~mc-return/compiz/compiz.merge-fix1196345-ccsm-key-caption-vertical-alignment-fixed into lp:compiz/0.9.10

Proposed by MC Return
Status: Merged
Approved by: Brandon Schaefer
Approved revision: 3751
Merged at revision: 3753
Proposed branch: lp:~mc-return/compiz/compiz.merge-fix1196345-ccsm-key-caption-vertical-alignment-fixed
Merge into: lp:compiz/0.9.10
Diff against target: 17 lines (+2/-2)
1 file modified
compizconfig/ccsm/ccm/Widgets.py (+2/-2)
To merge this branch: bzr merge lp:~mc-return/compiz/compiz.merge-fix1196345-ccsm-key-caption-vertical-alignment-fixed
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+172257@code.launchpad.net

Commit message

CCSM:
Fixed vertical alignment of the text on the stylized keys.
(Shift, Super, Ctrl, Alt)

(LP: #1196345)

Description of the change

It is a minor bug, but it was unpleasant on the eyes each time... ;)

Screenshot of the fixed version here: https://bugs.launchpad.net/compiz/+bug/1196345/+attachment/3719758/+files/keys_text_correct_alignment.png

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

LGTM. If this does break some sort of design docs that I cant locate this will be easy to fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'compizconfig/ccsm/ccm/Widgets.py'
--- compizconfig/ccsm/ccm/Widgets.py 2012-09-04 08:43:45 +0000
+++ compizconfig/ccsm/ccm/Widgets.py 2013-06-30 23:12:26 +0000
@@ -446,11 +446,11 @@
446 cr.fill_preserve ()446 cr.fill_preserve ()
447 if mod in self._current:447 if mod in self._current:
448 cr.set_source_rgb (0.3, 0.3, 0.3)448 cr.set_source_rgb (0.3, 0.3, 0.3)
449 self.write (cr, x + 23, y + 12, text)449 self.write (cr, x + 23, y + 15, text)
450 cr.set_source_rgb (0.5, 1, 0)450 cr.set_source_rgb (0.5, 1, 0)
451 else:451 else:
452 cr.set_source_rgb (0, 0, 0)452 cr.set_source_rgb (0, 0, 0)
453 self.write (cr, x + 22, y + 11, text)453 self.write (cr, x + 22, y + 14, text)
454454
455 def write (self, cr, x, y, text):455 def write (self, cr, x, y, text):
456 cr.move_to (x, y)456 cr.move_to (x, y)

Subscribers

People subscribed via source and target branches

to all changes: