Code review comment for lp:~mc-return/compiz/compiz.merge-fix1166195-fix1166196-fix116245-resizeinfo-fixes

Revision history for this message
MC Return (mc-return) wrote :

>
> These were the only changes that were actually substantial:
>
> 77 -const unsigned short RESIZE_POPUP_WIDTH = 85;
> 78 -const unsigned short RESIZE_POPUP_HEIGHT = 50;
> 79 +const unsigned short RESIZE_POPUP_WIDTH = 100;
> 80 +const unsigned short RESIZE_POPUP_HEIGHT = 33;
>
> 149 pango_font_description_set_family (font,"Sans");
> 150 - pango_font_description_set_absolute_size (font, 12 * PANGO_SCALE);
> 151 + pango_font_description_set_absolute_size (font,
> 152 + is->optionGetResizeinfoFontSize () *
> 153 + PANGO_SCALE);
> 154 pango_font_description_set_style (font, PANGO_STYLE_NORMAL);
> 155 - pango_font_description_set_weight (font, PANGO_WEIGHT_BOLD);
> 156 -
> 157 +
> 158 + if (is->optionGetResizeinfoFontBold ())
> 159 + pango_font_description_set_weight (font, PANGO_WEIGHT_BOLD);
> 160 + else
> 161 + pango_font_description_set_weight (font, PANGO_WEIGHT_NORMAL);
>
> As for those changes, they seem fine to me. I haven't got time to look at the
> formatting things just yet though.
> 162 +

TBH, the most substantial change in this MP was not listed by you ;)
It is this:

241 - (x + RESIZE_POPUP_WIDTH + 5),
242 - (y + RESIZE_POPUP_HEIGHT + 5));
243 + (RESIZE_POPUP_WIDTH + 5),
244 + (RESIZE_POPUP_HEIGHT + 5));

It reduces the damage rectangle's size by the window size...

« Back to merge proposal