lp:~mc-return/compiz/compiz.merge-fix1165198-horizontally-semimaximized-windows-do-not-snap-off-easily

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3654

PS Jenkins bot (community): Approve (continuous-integration) on 2013-04-13

Sam Spilsbury: Approve on 2013-04-13

MC Return: Pending requested 2013-04-11

Diff: 658 lines (+207/-181)

3 files modified

plugins/move/move.xml.in (+31/-10)
plugins/move/src/move.cpp (+169/-166)
plugins/move/src/move.h (+7/-5)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1165198: Move plugin: Horizontally semi-maximized windows do not snap off easily, in fact they do not snap off at all	Critical	Fix Released
Bug #1167208: Move plugin: Snapback for semimaximized windows should be configurable (on/off)	Wishlist	Fix Released
Bug #1167933: Move plugin: KEY_MOVE_INC, SNAP_BACK and SNAP_OFF are hardcoded and cannot be changed	Wishlist	Fix Released

Link a bug report

Related blueprints

3650. By MC Return on 2013-04-13

Removed commented out code and added TODO comments instead

3649. By MC Return on 2013-04-11

*Move xml:

Implemented options to configure:

"Snapoff Distance"
"Snapback Semimaximized Windows"
"Snapback Distance"

Improved a few tooltips.

*Move code:

Replaced SNAP_BACK and SNAP_OFF hardcoded constants
Made those configurable

Implemented snapping back of horizontally maximized windows and fixed
the snapping for vertically maximized windows

Fixed a few wrong calculations in the if condition checks responsible
for snapping off and back

Merged if condition checks

Just calculate various values if we do not return false

Removed redundant brackets, fixed indentation, improved readability

3648. By MC Return on 2013-04-08

move.cpp:
Removed redundant brackets
Declaration and assignment of local variables in one line, if possible
Alignment and indentation fixes

3647. By MC Return on 2013-04-07

move:
Implemented strategy to snap off horizontally semi-maximized windows by
dragging them along the x axis

3646. By MC Return on 2013-04-07

move:
Declare and assign variables in one line to improve readability

3645. By Gabriel Ebner on 2013-04-03

Adding a uniform to a GLVertexBuffer that uses AutoProgram causes compiz to segfault.

Example:
  gWindow->addShaders("cms", "", fragment_shader);
  gWindow->vertexBuffer()->addUniform("cms_lut", unit);
  // segfault happens later in PrivateVertexBuffer::render

The patch modifies PrivateVertexBuffer::render to set the uniform on the generated AutoProgram instead of the provided program, which in this case is NULL, causing a segfault.

(LP: #1162598). Fixes: https://bugs.launchpad.net/bugs/1162598.

Approved by PS Jenkins bot, Sam Spilsbury.

3644. By MC Return on 2013-04-03

Hopefully fixed all memory leaks in libcompizconfig.
Minor whitespace fixes.

(LP: #1076297). Fixes: https://bugs.launchpad.net/bugs/1076297.

Approved by PS Jenkins bot, Sam Spilsbury.

3643. By MC Return on 2013-03-30

Workspacenames:

Damage the text area correctly.
Extract the method used to determine where the text area was
into a separate function and use that to determine where our
damage area should be.
Also fix a few errors that happened on the last frame of animation.

This also fixes the flickering during display.

Other minor code refactoring.

(LP: #1075578, LP: #1162246). Fixes: https://bugs.launchpad.net/bugs/1075578, https://bugs.launchpad.net/bugs/1162246.

Approved by PS Jenkins bot, Sam Spilsbury.

3642. By MC Return on 2013-03-30

Show Desktop Upgrade:

Renamed "Show desktop" to "Show Desktop" (uppercase).

New features:

* Added individual movement options for all 4 corners.

* Implemented the new movement direction option "Intelligent Random".
  This option will make windows slide out of view in one of 3
  random directions (Top/Bottom / Left/Right / ToCorners) using the
  shortest movement distance, when Show Desktop is invoked.

* Also implemented a "Fully Random" movement direction mode, which will
  move every window out of view using one of 8 randomly chosen directions
  (one of 4 corners or one of 4 edges of the virtual screen).

enum IRDirection represents allowed directions in Intelligent Random
Direction mode, while enum FRDirection represents allowed directions
in Fully Random Direction mode.

Refactored ShowdesktopPlacer:
1. Removed #define macros and replaced them with inline functions in ::.
2. Refactored out the offset algorithms into separate functions.
3. Placed the actual offset + setting algorithms into ShowdesktopPlacer
and re-used where appropriate. This reduces the size of
ShowdesktopWindow::repositionPlacer.

Simplified void ShowdesktopScreen::donePaint () and removed redundant
damageScreen () call.

Removal of redundant brackets, declaration and assignment of variables in
the same line, indentation fixes, readability improvements and general
cleanup.

(LP: #1161343). Fixes: https://bugs.launchpad.net/bugs/1161343.

Approved by PS Jenkins bot, MC Return.

3641. By MC Return on 2013-03-30

Grid:
Fixed completely broken indentation.
Declaration and assignment of variables in one line.
Removed redundant brackets.

Approved by PS Jenkins bot, Sam Spilsbury.