lp:~mc-return/compiz/compiz.merge-fix1160878-wall-redundant-condition-check

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3640

PS Jenkins bot (community): Approve (continuous-integration) on 2013-03-28

Sam Spilsbury: Approve on 2013-03-28

Diff: 13 lines (+0/-3)

1 file modified

plugins/wall/src/wall.cpp (+0/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1160878: Wall plugin: Redundant if (screen->otherGrabExist ("wall", 0)) check in WallScreen::initiateFlip

Low

Fix Released

Link a bug report

Related blueprints

3640. By MC Return on 2013-03-27

wall.cpp:
Removed redundant check if (screen->otherGrabExist ("wall", 0)) in
bool WallScreen::initiateFlip (Direction direction, CompAction::State state),
because this check is already done a few lines earlier

3639. By MC Return on 2013-03-27

Removed empty and redundant CompWindow::syncPosition () function
and all calls to it.
Also removed some associated variables not needed anymore.

(LP: #1160624). Fixes: https://bugs.launchpad.net/bugs/1160624.

Approved by PS Jenkins bot, Sam Spilsbury.

3638. By Hu Kang <email address hidden> on 2013-03-27

put: Don't resize the option vector every time PutScreen::toViewport is called - this will leave stale values in the option vector. Instead, check if the option exists already and resize the vector that.

(LP: #1160710). Fixes: https://bugs.launchpad.net/bugs/1160710.

Approved by PS Jenkins bot, Sam Spilsbury.

3637. By Sam Spilsbury on 2013-03-27

Remove lots of superfluous boost::shared_static_cast usage, we only need it for the downcast situation (which in itself is a little silly).

Replace the remaining usage of boost::shared_static_cast with boost::static_pointer_cast.

(LP: #1131864). Fixes: https://bugs.launchpad.net/bugs/1131864.

Approved by PS Jenkins bot, MC Return.

3636. By Sam Spilsbury on 2013-03-25

Don't offset placement by window extents for windows that have a static
gravity.

Those windows want to be placed as though they didn't have decorations.

Get cp::constrainPositionToWorkArea under test and clean up the other
place tests too, so that they only test one thing at a time.

(LP: #1159324). Fixes: https://bugs.launchpad.net/bugs/1159234, https://bugs.launchpad.net/bugs/1159324.

Approved by PS Jenkins bot, MC Return.

3635. By Sam Spilsbury on 2013-03-23

Also decorate shadow-only windows. Strangely this fixes (LP: #1158161).

Refactor DecorWindow::update too and split up that function into separate bits. Fixes: https://bugs.launchpad.net/bugs/1158161.

Approved by PS Jenkins bot, Łukasz Zemczak, MC Return, Alfred Neumayer.

3634. By Sam Spilsbury on 2013-03-22

Use the actual change in window size to determine if we need to change
  the frame window size, don't just use the difference in frame extents
  to determine that.

  (LP: #1140505). Fixes: https://bugs.launchpad.net/bugs/1140505.

Approved by PS Jenkins bot, Sam Spilsbury.

3633. By Sam Spilsbury on 2013-03-13

Don't set lastFrameExtents unless the window geometry actually changed - as
that variable only exists to track changes in the actual geometry of
the window and not the apparant frame extents.

Added tests to verify that behaviour.

(LP: #1138517). Fixes: https://bugs.launchpad.net/bugs/1138517.

Approved by PS Jenkins bot, Timo Jyrinki.

3632. By Sam Spilsbury <email address hidden> on 2013-03-08

Added the plug-in "Freely Transformable Windows" aka freewins converted from git to bzr (including full history) to lp:compiz.

(LP: #1012194). Fixes: https://bugs.launchpad.net/bugs/1012194.

Approved by PS Jenkins bot, Sam Spilsbury.

3631. By Brandon Schaefer on 2013-03-08

Instead of not grabbing all the keys when IgnoreTap is set, add a patch to only not grab Super+P. Allowing part of this bug to say fix (LP:950160), while fixing bugs such as this (LP:1075207). This is only a patch for unity, otherwise it will not cause any problems with trunk compiz. Fixes: https://bugs.launchpad.net/bugs/1075207.

Approved by Andrea Azzarone, Sam Spilsbury, PS Jenkins bot.