Code review comment for lp:~mc-return/compiz/compiz.merge-fix1116538-isgridresized-windows-do-not-react-to-strg-super-down.2

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

> The only problem we have with this solution is -
> we have to make sure that the shortcuts are harmonized...
>
> That is why I would propose a combination of this with
> optional enhancement of Grid, so the user can choose
> to also use Grid to restore, or restore and minimize,
> if the Grid restore shortcut is not harmonized with
> core...
>

From a design point of view "restore_or_minimize" semantics don't make sense for the grid plugin. They only make sense as part of a kind of global "restore keybinding" that we already get from core.

> That way we could make everyone happy and would give
> users the possibility to use a different shortcut for
> Grid restore than core uses for
> unmaximize/unmaximize_or_minimize.
>
> We should IMHO find a perfect solution, without any
> compromises...

« Back to merge proposal