Code review comment for lp:~mc-return/compiz/compiz.merge-fix1106270-showmouse-plugin-needs-port-to-GLES

Revision history for this message
MC Return (mc-return) wrote :

> Again, well done, thanks for the effort.
>
Most credit in this case goes to Michail Bitzes.

> The only things I would point out are:
>
> 1. You probably need to update .install.armhf too (only .install.armel is
> updated)

Seems I forgot to save the file before the commit. Thanks for noticing. Fixed.

> 2. Coding style: spaces between both brackets () and operators foo + bar not
> foo+ bar

I hope I got them all. We need to fix those for firepaint as well then, seems
they slipped through there as well...

review: Needs Resubmitting

« Back to merge proposal