> This all looks fine, the only bit I have a concern over is:
>
> 18 - int nE = MIN (10, optionGetEmitters ());
> 19 + unsigned int nE = optionGetEmitters ();
>
> That would change behaviour, but I guess the point is that the real minimum
> should be controlled by the user, yes?
nE is just the number of Emitters, which is controlled by showmouse.xml.in anyway
and can just take values from 1 to 10, so there is no need for a type conversion
and also no need to calculate this minimum...
But I will set this branch to WIP for now as it will collide with the GL|ES
port anyway and I will probably have to fix conflicts before this can merge...
> This all looks fine, the only bit I have a concern over is:
>
> 18 - int nE = MIN (10, optionGetEmitters ());
> 19 + unsigned int nE = optionGetEmitters ();
>
> That would change behaviour, but I guess the point is that the real minimum
> should be controlled by the user, yes?
nE is just the number of Emitters, which is controlled by showmouse.xml.in anyway
and can just take values from 1 to 10, so there is no need for a type conversion
and also no need to calculate this minimum...
But I will set this branch to WIP for now as it will collide with the GL|ES
port anyway and I will probably have to fix conflicts before this can merge...