Code review comment for lp:~mc-return/compiz/compiz.merge-fix1105969-showmouse-code-needs-cleanup

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

This all looks fine, the only bit I have a concern over is:

18 - int nE = MIN (10, optionGetEmitters ());
19 + unsigned int nE = optionGetEmitters ();

That would change behaviour, but I guess the point is that the real minimum should be controlled by the user, yes?

review: Needs Information

« Back to merge proposal