This is all good as is.
Generally stuff like this:
44 + snprintf (path, 256, "%s/%s/%s/%s", COMPIZ_DBUS_ROOT_PATH, 45 plugin.c_str (), "options", o->name ().c_str ());
scares me because it can be truncated quite easily (leading to subtle problems). But, it isn't a problem with this review generally and we can fix it later.
« Back to merge proposal
This is all good as is.
Generally stuff like this:
44 + snprintf (path, 256, "%s/%s/%s/%s", COMPIZ_ DBUS_ROOT_ PATH,
45 plugin.c_str (), "options", o->name ().c_str ());
scares me because it can be truncated quite easily (leading to subtle problems). But, it isn't a problem with this review generally and we can fix it later.