Code review comment for lp:~mc-return/compiz/compiz.merge-fix1101641-use-snprintf-instead-of-sprintf

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

This is all good as is.

Generally stuff like this:

44 + snprintf (path, 256, "%s/%s/%s/%s", COMPIZ_DBUS_ROOT_PATH,
45 plugin.c_str (), "options", o->name ().c_str ());

scares me because it can be truncated quite easily (leading to subtle problems). But, it isn't a problem with this review generally and we can fix it later.

review: Approve

« Back to merge proposal