Code review comment for lp:~mc-return/compiz/compiz.merge-fix1082001-gridded-windows-jump-workspaces

Revision history for this message
MC Return (mc-return) wrote :

> Sure, before that, can you:
>
> 1. Look into merging some of the bitflags (at the very least, doing if
> (where & ~(GridLeft | GridRight | GridTop | GridBottom) is much better
> than doing where & ~(GridLeft) || where &~(GridRight) etc
> 2. Look into whether or not an enum can replace those bools, as they
> seem to be mutually exclusive.
>
1 & 2: Done. Even simplified one complicated if condition check additionally.
       I used 3 new bools, like you suggested before - it is much nicer already.
       I think an enum is not necessary here, the bools seem to be enough to
       clean that mess up.

review: Needs Resubmitting

« Back to merge proposal