Code review comment for lp:~mc-return/compiz/compiz.merge-fix1082001-gridded-windows-jump-workspaces

Sure, before that, can you:

1. Look into merging some of the bitflags (at the very least, doing if
(where & ~(GridLeft | GridRight | GridTop | GridBottom) is much better
than doing where & ~(GridLeft) || where &~(GridRight) etc
2. Look into whether or not an enum can replace those bools, as they
seem to be mutually exclusive.

On Tue, Apr 9, 2013 at 5:59 AM, MC Return <email address hidden> wrote:
> Sam, it would really be cool if we could merge this at current stage as it is a quasi Grid milestone.
>
> Also I got another branch I stacked on this one:
> https://code.launchpad.net/~mc-return/compiz/compiz.merge-fix1116538-isgridresized-windows-do-not-react-to-strg-super-down/+merge/157759
>
> and making too many changes here will complicate further merging :(
>
> I can assure you this here fully works, but I am somehow too lazy to make a video proving that all those bugs are fixed... ;)
>
> Sam, I can assure you I will get to all of your points in a later follow-up MP, but please give this one here a green light first ;)
> --
> https://code.launchpad.net/~mc-return/compiz/compiz.merge-fix1082001-gridded-windows-jump-workspaces/+merge/157760
> Your team Compiz Maintainers is requested to review the proposed merge of lp:~mc-return/compiz/compiz.merge-fix1082001-gridded-windows-jump-workspaces into lp:compiz.

--
Sam Spilsbury