Merge lp:~mc-return/compiz/compiz.merge-fix-memory-leaks-in-libcompizconfig into lp:compiz/0.9.9
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~mc-return/compiz/compiz.merge-fix-memory-leaks-in-libcompizconfig | ||||
Merge into: | lp:compiz/0.9.9 | ||||
Diff against target: |
101 lines (+32/-4) 1 file modified
compizconfig/libcompizconfig/src/main.c (+32/-4) |
||||
To merge this branch: | bzr merge lp:~mc-return/compiz/compiz.merge-fix-memory-leaks-in-libcompizconfig | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Trevisan (Treviño) | Needs Resubmitting | ||
Daniel van Vugt | Needs Fixing | ||
MC Return | Needs Resubmitting | ||
Review via email: mp+133432@code.launchpad.net |
This proposal has been superseded by a proposal from 2013-04-02.
Commit message
libcompizconfig memory leak fixes:
Fixed memory leak in static Bool ccsProcessSetti
Free the memory pointed to by *SectionName if (asprintf (&keyName, "-s%d_%s", cPrivate-
Fixed memory leak in static Bool ccsProcessSetti
Free the memory *sectionName is pointing to if (!newSetting) before returning FALSE.
(LP: #1076297)
Description of the change
Note: Usually switch-case commands do not use {} brackets for the individual cases, but I kept the style already used.
Note 2: case TypeAction has no break, so it is the same as default (probably intentional).
Unmerged revisions
- 3467. By MC Return
-
Merged latest lp:compiz
- 3466. By MC Return
-
Hopefully fixed all remaining leaks
- 3465. By MC Return
-
Merged latest lp:compiz
- 3464. By MC Return
-
Merged latest lp:compiz
- 3463. By MC Return
-
Added forgotten brackets
- 3462. By MC Return
-
Free newSetting and sectionName in the case TypeAction and default
- 3461. By MC Return
-
Also free (newSetting) by default if other cases do not match
- 3460. By MC Return
-
Merged latest lp:compiz
- 3459. By MC Return
-
Hopefully fixed all remaining potential memory leaks caused by sectionName
- 3458. By MC Return
-
Fixed memory leak in static Bool ccsProcessSetti
ngMinus (...)
Free the memory pointed to by *SectionName if (asprintf (&keyName, "-s%d_%s", cPrivate->screenNum, ccsSettingGetName (setting)) == -1) also
One branch/proposal per bug please. It gets too confusing for Launchpad when there are multiple branches to fix a single bug.