Merge lp:~mc-return/compiz/compiz.merge-fix-memory-leak-in-decorator into lp:compiz/0.9.9
Proposed by
MC Return
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Daniel van Vugt | ||||
Approved revision: | 3455 | ||||
Merged at revision: | 3460 | ||||
Proposed branch: | lp:~mc-return/compiz/compiz.merge-fix-memory-leak-in-decorator | ||||
Merge into: | lp:compiz/0.9.9 | ||||
Diff against target: |
14 lines (+3/-0) 1 file modified
gtk/window-decorator/decorator.c (+3/-0) |
||||
To merge this branch: | bzr merge lp:~mc-return/compiz/compiz.merge-fix-memory-leak-in-decorator | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel van Vugt | Approve | ||
MC Return | Needs Resubmitting | ||
Sam Spilsbury | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+133423@code.launchpad.net |
Commit message
Hopefully fixed a memory leak in void update_
The pointer *opts allocates a memory block and stores the adress, but if the pointer *info fails later this memory does not get freed.
Solution: Free and NULL opts, if (!info) also.
(LP: #1033879)
To post a comment you must log in.
9 + {
10 + free (opts);
11 + opts = NULL;
12 + return;
13 + }
Good, just change the indentation of { } to align with the if () and remove the redundant opts = NULL;