lp:~mc-return/compiz/compiz.merge-fix-memory-leak-in-decorator

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.9 at revision 3460

Daniel van Vugt: Approve on 2012-11-09

MC Return: Needs Resubmitting on 2012-11-08

Sam Spilsbury: Approve on 2012-11-08

PS Jenkins bot: Pending (continuous-integration) requested 2012-11-09

Diff: 14 lines (+3/-0)

1 file modified

gtk/window-decorator/decorator.c (+3/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1033879: Memory leak in decorator reported by cppcheck

Medium

Fix Released

Link a bug report

Related blueprints

3455. By MC Return on 2012-11-08

Fixed indentation and removed the redundant opts = NULL;

3454. By MC Return on 2012-11-08

Hopefully fixed a memory leak in void update_frames_shadows (gpointer key, gpointer value, gpointer user_data)
The pointer *opts allocates a memory block and stores the adress, but if the pointer *info fails later this memory does not get freed

3453. By MC Return on 2012-11-06

Resizeinfo Plug-in:
Fixed options to change Gradient Color 2 and Gradient Color 3 having no effect and enabled possibility for a gradient background.
(LP: #1070233). Fixes: https://bugs.launchpad.net/bugs/1070233. Approved by Daniel van Vugt, Sam Spilsbury.

3452. By MC Return on 2012-11-06

Resizeinfo Plug-In:
Added option to change the color of the background's outline.
(LP: #1070297)

Also renamed 'gradientChanged' to 'backgroundColorChanged'.. Fixes: https://bugs.launchpad.net/bugs/1070297. Approved by Daniel van Vugt, Sam Spilsbury.

3451. By Michael Terry on 2012-11-06

Bring debian/ packaging inline.

Reviewed/tested/approved by Daniel van Vugt.

3450. By MC Return on 2012-11-05

Shift Switcher: Minor optimization: As we return in both cases one if statement is enough here (x2).. Approved by Daniel van Vugt, Sam Spilsbury.

3449. By MC Return on 2012-11-05

Initialized all class member variables in their respective constructors.
Used false for bools, 0 for ints. (LP: #1033877). Fixes: https://bugs.launchpad.net/bugs/1033877. Approved by Daniel van Vugt.

3448. By MC Return on 2012-11-05

Check on which display your pointer is at, before calculating edges/corners for the snap preview.

The problem here is that detection (if the cursor enters another output) is done after the trigger edges have already been detected and calculated, so if you enter a new screen the preview will still have the old values and not follow the mousepointer to the new monitor. Then if you release the mousebutton the resize won't follow the preview, but resize correctly on the monitor your cursor is currently at, while still showing the old preview.

(LP: #1068173). Fixes: https://bugs.launchpad.net/bugs/1068173. Approved by Daniel van Vugt, Sam Spilsbury.

3447. By MC Return on 2012-11-05

Initialized all class member variables in their respective constructors.
Used false for bools, 0.0f for floats, 0 for ints and 0 for object pointers like *autoProgram and *screen.. Fixes: https://bugs.launchpad.net/bugs/1033877. Approved by Stephen M. Webb, Sam Spilsbury.

3446. By MC Return on 2012-11-01

Re-added GL_BLEND code to the non-GLES codepath to fix the regression caused by r3320.
Fixes scaleaddon window highlight being rendered solid.

(LP #1068503). Fixes: https://bugs.launchpad.net/bugs/1068503. Approved by Sam Spilsbury, Daniel van Vugt.