Code review comment for lp:~mc-return/compiz/compiz.merge-ezoom-cleanup

Revision history for this message
MC Return (mc-return) wrote :

>
> #define WIDTHOK (float)(x2-x1) / (float)o->width () < zooms.at (out).newZoom
> #define HEIGHTOK (float)(y2-y1) / (float)o->height () < zooms.at (out).newZoom
>
> ...
>
> 541 if (WIDTHOK &&
> 542 - HEIGHTOK) {
> 543 + HEIGHTOK)
> 544 + {
>
> Its an extraneous point, but remove these macros and replace them with inline
> functions if you can.
>
Looking at it in detail, no inline function is even needed. Replaced those macros
with local bools.

review: Needs Resubmitting

« Back to merge proposal