Code review comment for lp:~mc-return/compiz/compiz.merge-composite-cleanup

Revision history for this message
MC Return (mc-return) wrote :

> 360 + if (priv->optionGetForceIndependentOutputPainting () ||
> 361 + !screen->hasOverlappingOutputs ())
> 362 foreach (CompOutput &o, screen->outputDevs ())
> 363 + {
> 364 outputs.push_back (&o);
> 365 - }
> 366 + }
> 367 else
>
> Hmm, there is still this one here.
>
> I suggested earlier that where you have nested bodies of if () or for ()
> statements which have brackets then the parent if () or for () control flow
> statement should also have brackets.
>
> So the rule would be:
>
> if (foo)
> {
> if (bar)
> {
> }
> } // OK
>
> if (foo)
> if (bar)
> {
> } // Bad
>
> if (foo)
> {
> if (bar)
> baz (); // OK
> }

I understood that, but here it was:
357 - if (priv->optionGetForceIndependentOutputPainting ()
358 - || !screen->hasOverlappingOutputs ())
359 - {
362 foreach (CompOutput &o, screen->outputDevs ())
364 outputs.push_back (&o);
365 - }

Now it is:

360 + if (priv->optionGetForceIndependentOutputPainting () ||
361 + !screen->hasOverlappingOutputs ())
362 foreach (CompOutput &o, screen->outputDevs ())
363 + {
364 outputs.push_back (&o);
366 + }

But if you like me to re-add the if brackets, I can do that ofc.

« Back to merge proposal