Code review comment for lp:~mc-return/compiz/compiz.merge-annotate-cleanup

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

25 /* draw rectangle outline */
626 -/* streamingBuffer->begin ();
627 + streamingBuffer->begin ();
628
629 streamingBuffer->addColors (1, optionGetStrokeColor ());
630
631 @@ -777,7 +761,7 @@
632 glRecti (rectangle.x1 () - offset, rectangle.y1 () + offset,
633 rectangle.x2 () + offset, rectangle.y1 () - offset);
634 glRecti (rectangle.x1 () - offset, rectangle.y2 () + offset,
635 - rectangle.x2 () + offset, rectangle.y2 () - offset);*/
636 + rectangle.x2 () + offset, rectangle.y2 () - offset);

That will break on GLES builds, glRecti isn't supported there.

Can you convert this to use GL_TRIANGLE_STRIP?

review: Needs Fixing

« Back to merge proposal