Code review comment for lp:~mc-return/compiz/compiz.fix1030473-part3

Revision history for this message
MC Return (mc-return) wrote :

Also in /gtk/window-decorator/cairo.c:732 in static void
calc_button_size (decor_t *d) we can find this:

    if (d->actions & (WNCK_WINDOW_ACTION_MINIMIZE |
        WNCK_WINDOW_ACTION_MINIMIZE))
 button_width += 17;

In the function static void calc_button_size (decor_t *d) button_width is first declared with

    gint button_width;

then assigned the value

    button_width = 0;

which could also be reduced to

    gint button_width = 0;

and then button_width is increased by 17 (pixels) for respective available window actions, so if the close action is valid, it is increased by 17 points, then for the maximize/restore button if any of the window actions for maximizing and unmaximizing are available, the third button would always be minimize then and we should fix this by changing:

    if (d->actions & (WNCK_WINDOW_ACTION_MINIMIZE |
        WNCK_WINDOW_ACTION_MINIMIZE))
 button_width += 17;

to

    if (d->actions & WNCK_WINDOW_ACTION_MINIMIZE)
 button_width += 17;

« Back to merge proposal