Code review comment for lp:~mbruzek/charms/precise/rabbitmq-server/add-tests

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thank you for the amulet test coverage work on rmq, much appreciated!

If we can get this added to Makefile, that will make OSCI's engine happy:

test:
    @echo Starting amulet tests...
    @juju test -v -p AMULET_HTTP_PROXY --timeout 900

I just sent your branch with ^ that mod through to confirm:
  juju-test.conductor.00_setup.sh RESULT : ✔
  juju-test.conductor.10_basic_deploy_test.py RESULT : ✔
  juju-test.conductor.20_deploy_relations_test.py RESULT : ✔
  juju-test.conductor.30_configuration_test.py RESULT : ✔
  juju-test INFO : Results: 4 passed, 0 failed, 0 errored

I think most of the openstack charms use the 'test' target name. But actually, you can name the make target anything as OSCI just looks for '@juju test' in a target and runs that target.

« Back to merge proposal