Merge lp:~mbruzek/charms/precise/pubphoto/trunk into lp:~jose/charms/precise/pubphoto/trunk

[Matt Bruzek]

Jose,

I was looking at pubphoto and I made some improvements to the README. Please consider these changes.

Also I have been notified that the Chris Lea got hired by nodesource and node.js install has changed. I believe the install hook will works for precise but you might want to explore alternate installs of node.js so it would be an easier transition to trusty.

https://gist.github.com/marcoceppi/d8143918b7ab7667aa85

wget -qO- https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add -

echo "deb https://deb.nodesource.com/node $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/nodesource.list
echo "deb-src https://deb.nodesource.com/node $(lsb_release -cs) main" | sudo tee -a /etc/apt/sources.list.d/nodesource.list

sudo apt-get update
sudo apt-get install nodejs

[Matt Bruzek (mbruzek)]

When looking at pubphoto on github (https://github.com/stuartlangridge/pubphoto) I see two names for the project, pubphoto is in the URL but soonsnap (http://soonsnap.com) is referenced. If they are changing the name we should get this sorted before adding to the charm store.

[José Antonio Rey (jose)]

Hey Matt,

According to sil, the webpage is named soonsnap, but the service is called pubphoto.

Will review later today.

[José Antonio Rey (jose)]

+1 LGTM

Thanks, Matt! :)

review: Approve

=== modified file 'README.md'
--- README.md	2014-09-11 01:43:08 +0000
+++ README.md	2014-11-26 16:30:24 +0000
@@ -5,13 +5,13 @@
 for another user to download or access the photo, they can just access the
 webpage and enter the code, and the photo will be available for them.
 
-This charm will deploy and configure PubPhoto for its usage.
+This charm will deploy and configure PubPhoto for use in the cloud.
 
 # Usage
 
 First, bootstrap your environment:
 
-    juju boostrap
+    juju bootstrap
 
 Then, deploy the PubPhoto service:
 
@@ -19,7 +19,7 @@
 
 Wait a couple minutes, and discover the address by executing:
 
-    juju status
+    juju status pubphoto
 
 You can browse to the service by going to the public address. You're all set
 now!
@@ -58,9 +58,9 @@
 # Contact Information
 
 Author: José Antonio Rey <[e-mail]>  
-Report bugs at: http://bugs.launchpad.net/charms/+source/pubphoto  
-Location: http://jujucharms.com/  
+Report bugs with the charm at: http://bugs.launchpad.net/charms/+source/pubphoto  
 
-## Upstream Project Name
+## PubPhoto
 
 - [Git page for PubPhoto](https://github.com/stuartlangridge/pubphoto)
+- [Issue tracker for PubPhoto](https://github.com/stuartlangridge/pubphoto/issues)