Code review comment for lp:~mbp/testresources/doc

Revision history for this message
Martin Pool (mbp) wrote :

On 23 October 2012 07:44, Robert Collins <email address hidden> wrote:

> Review: Approve
>
> Thanks for this, I shall look at it locally to see what the whitespace
> changes are and merge it.
>
> I'd be happy to have specific managers that depend only on the standard
> library in testresources. For tempdir though,
> FixtureResource(fixtures.TempDir) should be all you need. Many things are
> probably best expressed as fixtures, not as resources + resource managers,
> and used via FixtureResource.
>
>
Could I persuade you to make a release with FixtureResource some time?

--
Martin

« Back to merge proposal