Code review comment for lp:~mbp/rabbitfixture/rabbit-startup

Revision history for this message
Martin Pool (mbp) wrote :

On 24 October 2011 17:02, Robert Collins <email address hidden> wrote:
> The change to the exception may confuse folk, because the config
> workarea gets deleted entirely [when used with transient rabbits in
> tests]

I found that:

1- the log file is directly in /tmp, eg /tmp/tmpj8LKTv
2- when the tests failed, the log file was still present

and so for me it was useful.

There may be other cases where the log file is already deleted by the
time you see the exception. I thought about trying to read it into
memory and put it in the exception but it's fairly long.

« Back to merge proposal