Code review comment for lp:~mbp/python-oops-datedir-repo/bsondump

Revision history for this message
Robert Collins (lifeless) wrote :

Other issues (fixing, but noting for easier ride next time:)

the new script was missing (C) header stuff (nab from any other file in the project).

No tests (I'm ignoring this for now given it's triviality... I bet this will bite later tho!)

bson doesn't handle multiple documents well, so using named files only is fine IMO.

review: Approve

« Back to merge proposal