Code review comment for lp:~mbp/launchpad/meta-description

Revision history for this message
Martin Pool (mbp) wrote :

Thanks for the review.

I will test the actual content.

On consideration, I think I will strip email addresses always, since the description is commonly used by sharing tools and they shouldn't share the email address, even when started by an authenticated user.

> Don't you want to return u'' on line 250 here?

No I think I do want None, so the description just doesn't appear.

« Back to merge proposal