Merge lp:~mbp/launchpad/855150-no-potemplate-mail into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14034 |
Proposed branch: | lp:~mbp/launchpad/855150-no-potemplate-mail |
Merge into: | lp:launchpad |
Diff against target: |
61 lines (+13/-18) 2 files modified
lib/lp/translations/doc/poimport.txt (+2/-14) lib/lp/translations/model/potemplate.py (+11/-4) |
To merge this branch: | bzr merge lp:~mbp/launchpad/855150-no-potemplate-mail |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Launchpad code reviewers | Pending | ||
Review via email: mp+76878@code.launchpad.net |
Commit message
[r=danilo][bug=855150] stop sending "you uploaded a translation template" mails
Description of the change
This just stops sending "you uploaded a translation template for bzr in Bazaar trunk in Launchpad" mails when potemplates are imported. At the moment they are sent to a large group of people, most of whom likely see this as spam (in the case I looked at.)
I don't know if there are other people who do like getting these mails or count on getting them to know things are working properly. I doubt they are very useful because there's so little content. Possibly we want some in-web view of when templates were imported (if it's not already obvious) or some way for people to opt-in to get mail about it, but in the absence of that this still seems like a step forward.
danilos said he thought this was a reasonable step.
No tests fail in the subset I ran.
Actually, there was a test for this, which failed on ec2. I'll update it.