Merge lp:~mbp/launchpad/800295-protocol into lp:launchpad

Proposed by Martin Pool
Status: Merged
Approved by: Martin Pool
Approved revision: no longer in the source branch.
Merged at revision: 14327
Proposed branch: lp:~mbp/launchpad/800295-protocol
Merge into: lp:launchpad
Diff against target: 20 lines (+1/-2)
1 file modified
lib/lp/buildmaster/model/builder.py (+1/-2)
To merge this branch: bzr merge lp:~mbp/launchpad/800295-protocol
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+82629@code.launchpad.net

Commit message

[r=mbp][no-qa] Remove runtime non-test dependency of buildmaster on buildd code

Description of the change

stop lp non-test code importing buildd slave code - one more bit for bug 800295 - thanks wgrant

To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

going to send this in based on wgrant's previously saying to make just this change

Revision history for this message
Martin Pool (mbp) wrote :
Revision history for this message
Martin Pool (mbp) wrote :

landing seems to be blocked by bug 890816

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/buildmaster/model/builder.py'
--- lib/lp/buildmaster/model/builder.py 2011-11-17 19:41:24 +0000
+++ lib/lp/buildmaster/model/builder.py 2011-11-18 03:01:25 +0000
@@ -43,7 +43,6 @@
43from zope.component import getUtility43from zope.component import getUtility
44from zope.interface import implements44from zope.interface import implements
4545
46from canonical.buildd.slave import BuilderStatus
47from canonical.config import config46from canonical.config import config
48from canonical.database.sqlbase import (47from canonical.database.sqlbase import (
49 SQLBase,48 SQLBase,
@@ -692,7 +691,7 @@
692 return False691 return False
693692
694 def check_available(status):693 def check_available(status):
695 return status[0] == BuilderStatus.IDLE694 return status[0] == 'BuilderStatus.IDLE'
696 return d.addCallbacks(check_available, catch_fault)695 return d.addCallbacks(check_available, catch_fault)
697696
698 def _getSlaveScannerLogger(self):697 def _getSlaveScannerLogger(self):