Code review comment for lp:~mbp/launchpad/612171-diff-generation-spam
Revision history for this message
| Martin Pool (mbp) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
OK, thanks for your patient reviews, here's another update:
* add a test that the job wants to retry on pending writes and that no mail is sent
* fix up the tuple thing
* simplify (or maybe correct) the code that says the job can be retried
Happily the test does fail if retry_error_types is not a tuple.